Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soft reload breaks button on new chrome web store preview #128

Closed
NeverDecaf opened this issue Sep 26, 2023 · 3 comments
Closed

soft reload breaks button on new chrome web store preview #128

NeverDecaf opened this issue Sep 26, 2023 · 3 comments

Comments

@NeverDecaf
Copy link
Owner

If you click the title of an extension:
image
the page will be soft reloaded, which seems to break any chrome.runtime messaging connections, causing the button to stop functioning. Handling this error is not trivial (for me) but this functionality in the store doesn't even make sense in the first place. Hopefully Google will simply remove this functionality before launch.
@NeverDecaf
Copy link
Owner Author

I am considering appending target="_blank" to the anchor <a> but I don't like the idea of modifying other parts of the page besides the Add to Chrome button. (although this is a fairly benign change)

@NeverDecaf
Copy link
Owner Author

target=_top makes more sense, also want to add that this doesn't just happen when you click the header, navigating between pages on the store also has this effect

@NeverDecaf
Copy link
Owner Author

NeverDecaf commented Feb 8, 2024 •
edited
Loading

Switched to an alternative method, but the same type of bug persists: #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeverDecaf