Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protecting names in schema language #1

Open
bendichter opened this issue Dec 29, 2019 · 0 comments
Open

protecting names in schema language #1

bendichter opened this issue Dec 29, 2019 · 0 comments

Comments

@bendichter
Copy link

Right now the schema language document does not indicate that there are any rules for name, default_name, neurodata_def, or neurodata_inc. I think we should add this pattern:
"^[A-Za-z_][A-Za-z0-9_]*$"
which means each name must start with a letter can can contain letters, numbers, and underscores, but not spaces, periods, or other punctuation.

The motivations are:

  1. matnwb has issues when names contain spaces.
  2. pynwb has issues when names contain slashes.
  3. This allows us to more easily create classes with names that match the schema, which is not strictly necessary but is a good idea.

The entire core schema currently follows this rule.

@oruebel oruebel transferred this issue from NeurodataWithoutBorders/nwb-schema Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant