Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiving/nsg: include HDF5 exports #285

Open
sanjayankur31 opened this issue Dec 6, 2023 · 2 comments · May be fixed by #286
Open

archiving/nsg: include HDF5 exports #285

sanjayankur31 opened this issue Dec 6, 2023 · 2 comments · May be fixed by #286
Labels
T: enhancement Type: enhancement

Comments

@sanjayankur31
Copy link
Member

The archival does not currently include HDF5 files. This function needs to be updated:

https://github.com/NeuroML/pyNeuroML/blob/development/pyneuroml/archive/__init__.py#L107
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Dec 6, 2023
sanjayankur31 added a commit that referenced this issue Dec 6, 2023
@sanjayankur31
feat(archive): also handle h5 files
22da195 
Fixes #285
@sanjayankur31 sanjayankur31 linked a pull request Dec 6, 2023 that will close this issue
Draft
@YBCS
Copy link
Contributor

YBCS commented Apr 16, 2024

@sanjayankur31 can I work on this ?

@sanjayankur31 sanjayankur31 linked a pull request Apr 16, 2024 that will close this issue
feat(archive): also handle h5 files #286
Draft
@sanjayankur31
Copy link
Member Author

This one already has a partial PR, so maybe work on #279 first and if this is still open when you're done there, we can look at this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: enhancement Type: enhancement
Projects
NeuroML backlog
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(archive): also handle h5 files NeuroML/pyNeuroML
2 participants
@sanjayankur31 @YBCS