Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise modification of parameters in NeuroMLController #150

Open
sanjayankur31 opened this issue Dec 1, 2021 · 2 comments
Open

Generalise modification of parameters in NeuroMLController #150

sanjayankur31 opened this issue Dec 1, 2021 · 2 comments
Labels
good first issue A good issue for newcomers to work on Help wanted T: enhancement Type: enhancement

Comments

@sanjayankur31
Copy link
Member

In:

https://github.com/NeuroML/pyNeuroML/blob/development/pyneuroml/tune/NeuroMLController.py#L260

we currently use a process where we hard code certain attributes that can be modified here during the tuning process, but it should be possible to just use an xpath like form that allows modification of any attributes.

That way we don't need to hard-code anything here

@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement Help wanted good first issue A good issue for newcomers to work on labels Dec 1, 2021
@Ragzz1995
Copy link

Ragzz1995 commented Dec 17, 2021

Hi. since I'm new to contributing to opensource projects, I thought I'll start off something with "good first issue tags". So, I hope it's okay if ask some rudimentary questions. By parameters do you mean the parameters passed to this function?

     def __init__(
        self,
        ref,
        neuroml_file,
        target,
        sim_time=1000,
        dt=0.05,
        simulator="jNeuroML",
        generate_dir="./",
        num_parallel_evaluations=1,
        cleanup=True,
    ):

Do you want to parse parameters from xml file using Xpath instead of hardcoding?

@sanjayankur31
Copy link
Member Author

Hi @Ragzz1995

Thanks for the comment.

No, at the moment, the path string used for to pass parameters to the run_optimisation function has a specific format, based on what we've hard-coded in the NeuroMLTuner, and we were wondering if we need to hard-code these or if we can use the usual xpath spec that we use in general with NeuroML. Here's an example code snippet,

https://github.com/NeuroML/Documentation/blob/master/source/Userdocs/NML2_examples/tune-izhikevich.py#L147

and here's where it's "hard-coded":
https://github.com/NeuroML/pyNeuroML/blob/master/pyneuroml/tune/NeuroMLController.py#L318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good issue for newcomers to work on Help wanted T: enhancement Type: enhancement
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants