solved valgrind memory issues (pass by reference vs pass by value pointer)

Author: NeuralCoder3

dialects/compile/compile.cpp

@@ -70,9 +70,10 @@ extern "C" THORIN_EXPORT thorin::DialectInfo thorin_get_dialect_info() {
                     int level = (int)(app->as<App>()->arg(0)->as<Lit>()->get<u64>());
                     world.DLOG("  Level: {}", level);
                     // TODO: add a debug pass to the pipeline
-                    builder.append_pass_after_end([&](PassMan& man) {
+                    builder.append_pass_after_end([=](PassMan& man) {
                         man.add<thorin::compile::DebugPrint>(level);
-                        // man.add<thorin::compile::DebugPrint>(1);
+                        // man.add<thorin::compile::DebugPrint>(level);
+                        // man.add<thorin::compile::DebugPrint>(42);
                     });
                 };
 

dialects/compile/compile.thorin

@@ -78,10 +78,8 @@
 /// 
 // TODO: allow functions by inlining them first
 .let optimization_phase = {
-    // TODO: it needs to be possible to add a pass twice and keep the instances separate (bind in pipeline/manager?)
     .let eta_red = %compile.eta_red_pass;
     .let eta_exp = %compile.eta_exp_pass eta_red;
-    // TODO: use pass_phase
     %compile.pass_phase (%compile.pass_list
         %compile.partial_eval_pass
         %compile.beta_red_pass

lit/compile/id.thorin

@@ -14,9 +14,9 @@
 
 .lam .extern _compile [] -> Pipeline = {
     %compile.pipe
-        (%compile.debug_phase 1)
+        // (%compile.debug_phase 1)
         (%compile.debug_phase 2)
-        (%compile.debug_phase 3)
+        // (%compile.debug_phase 3)
 };
 
 // CHECK-DAG: return{{.*}}42

thorin/dialects.cpp

@@ -85,8 +85,10 @@ Dialect Dialect::load(const std::string& name, Span<std::string> search_paths) {
                 plugin_path    = full_path.string();
 
                 std::error_code ignore;
-                if (bool reg_file = std::filesystem::is_regular_file(full_path, ignore); reg_file && !ignore)
-                    if (handle.reset(dl::open(full_path.string())); handle) break;
+                if (bool reg_file = std::filesystem::is_regular_file(full_path, ignore); reg_file && !ignore) {
+                    auto path_str = full_path.string();
+                    if (handle.reset(dl::open(path_str)); handle) break;
+                }
             }
             if (handle) break;
         }

thorin/pass/pipelinebuilder.h

@@ -41,8 +41,9 @@ class PipelineBuilder {
     // void add_pass(const Def*, Args&&...);
     template<class P, class... Args>
     void add_pass(const Def* def, Args&&... args) {
-        append_pass_in_end([&](PassMan& man) {
-            auto pass = (Pass*)man.add<P>(std::forward<Args>(args)...);
+        append_pass_in_end([&, def, ... args = std::forward<Args>(args)](PassMan& man) {
+            // auto pass = (Pass*)man.add<P>(std::forward<Args>(args)...);
+            auto pass = (Pass*)man.add<P>(args...);
             remember_pass_instance(pass, def);
         });
     }
@@ -77,14 +78,14 @@ class PipelineBuilder {
 // TODO: move somewhere better (for now here due to template restrictions)
 template<class A, class P>
 void register_pass(Passes& passes) {
-    passes[flags_t(Axiom::Base<A>)] = [&](World&, PipelineBuilder& builder, const Def* app) {
+    passes[flags_t(Axiom::Base<A>)] = [](World&, PipelineBuilder& builder, const Def* app) {
         builder.add_pass<P>(app);
     };
 }
 
 template<class A, class P, class Q>
 void register_pass_with_arg(Passes& passes) {
-    passes[flags_t(Axiom::Base<A>)] = [&](World&, PipelineBuilder& builder, const Def* app) {
+    passes[flags_t(Axiom::Base<A>)] = [](World&, PipelineBuilder& builder, const Def* app) {
         auto pass_arg = (Q*)(builder.get_pass_instance(app->as<App>()->arg()));
         builder.add_pass<P>(app, pass_arg);
     };