From 00044ff2572e62eeaa8b1709b4ab125297abf59e Mon Sep 17 00:00:00 2001 From: Devin Jean Date: Sat, 27 Apr 2024 08:19:50 -0500 Subject: [PATCH] fix send img crash (#230) * fix send img crash * Fix code formatting --------- Co-authored-by: Format Bot --- src/procedures/utils/api-consumer.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/procedures/utils/api-consumer.js b/src/procedures/utils/api-consumer.js index acc204ef..b83232f8 100644 --- a/src/procedures/utils/api-consumer.js +++ b/src/procedures/utils/api-consumer.js @@ -146,7 +146,7 @@ class ApiConsumer extends NBService { let requestImage = () => { logger.trace("requesting image from", fullUrl); const deferred = defer(); - const imgResponse = request.get(fullUrl); + const imgResponse = request.get(fullUrl, (err) => deferred.reject(err)); delete imgResponse.headers["cache-control"]; imgResponse.on("response", (res) => { try { @@ -240,11 +240,16 @@ class ApiConsumer extends NBService { } // sends an image to the user - _sendImage(queryOptions) { - return this._requestImage(queryOptions) - .then((imageBuffer) => { - this._sendImageBuffer(imageBuffer); - }); + async _sendImage(queryOptions) { + let img; + try { + img = await this._requestImage(queryOptions); + } catch (e) { + this._logger.trace("failed to load image", e); + return "failed to load image"; + } + + return this._sendImageBuffer(img); } // helper test the response