Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Fix function naming of functions inside traits #1064

Open
rodrigo-pino opened this issue May 22, 2023 · 0 comments
Open

Fix function naming of functions inside traits #1064

rodrigo-pino opened this issue May 22, 2023 · 0 comments
Assignees

Comments

@rodrigo-pino
Copy link
Contributor

Functions inside WarpMemory, are being called this way:

let x = warp_memory.get_or_create_id(...)

Because, currently warp_memory is invisible to the solidity AST, the warp_memory. prefix is included in the naming. So for the example above, get_or_create_id is actually called warp_memory.get_or_create_id.

Two possible solutions are including WarpMemory to the AST, and making all function calls part of a member access, or keep it hidden. The second one is fastest, and easy (it would be cool to implement it in a non hacky way)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant