-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC08 - starknet_getStorageProof #2180
Comments
@kirugan |
@estherbreath please consider other issues to implement. This one will be covered by someone from our team. |
In my opinion this method should be defined better or the result maybe be meaningless TL;DRInclusion proofs are linked with a particular state and info about the state is missing in the response Problem description
Imagine you request some class inclusion proof and the result is merkle paths that calculates to the class trie root. Therefore I propose that juno will return these (additional to the spec) informations. Juno should respond with the following: "result": {
"name": "result",
"description": "The contract's nonce at the requested state",
"schema": {
"type": "object",
"properties": {
"classes_proof": {
"$ref": "#/components/schemas/NODE_HASH_TO_NODE_MAPPING"
},
"contracts_proof": {
"$ref": "#/components/schemas/NODE_HASH_TO_NODE_MAPPING"
},
"contracts_storage_proofs": {
"type": "array",
"items": {
"$ref": "#/components/schemas/NODE_HASH_TO_NODE_MAPPING"
},
<!-- ADDITIONAL INFORMATIONS STARTS HERE 👇
"block_hash": {
"$ref": "#/components/schemas/FELT"
},
"global_state_root": {
"$ref": "#/components/schemas/FELT"
},
"contract_trie_root": {
"$ref": "#/components/schemas/FELT"
},
"class_trie_root": {
"$ref": "#/components/schemas/FELT"
},
}
}
} |
Specification - https://github.com/starkware-libs/starknet-specs/blob/v0.8.0-rc0/api/starknet_api_openrpc.json#L910
Changes in PR starkware-libs/starknet-specs#232
The text was updated successfully, but these errors were encountered: