From 3d0b89f70c8f4f8b520586ae05d420f8c5f08f23 Mon Sep 17 00:00:00 2001 From: Shashank Srikanth Date: Tue, 3 Sep 2024 01:32:08 -0700 Subject: [PATCH 1/3] Update deployer API to support more orchestrators --- metaflow/runner/deployer.py | 1 + 1 file changed, 1 insertion(+) diff --git a/metaflow/runner/deployer.py b/metaflow/runner/deployer.py index 354b45dde43..a18765d6c05 100644 --- a/metaflow/runner/deployer.py +++ b/metaflow/runner/deployer.py @@ -397,6 +397,7 @@ def create(self, **kwargs) -> DeployedFlow: self.name = content.get("name") self.flow_name = content.get("flow_name") self.metadata = content.get("metadata") + self.additional_metadata = content.get("additional_metadata", {}) if command_obj.process.returncode == 0: deployed_flow = DeployedFlow(deployer=self) From 588177e94bd7a3db94b36f423a73d7c8a493c8e4 Mon Sep 17 00:00:00 2001 From: Shashank Srikanth Date: Sun, 8 Sep 2024 18:43:11 -0700 Subject: [PATCH 2/3] Rebase and update docstring --- metaflow/runner/deployer.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/metaflow/runner/deployer.py b/metaflow/runner/deployer.py index a18765d6c05..3d161a1f139 100644 --- a/metaflow/runner/deployer.py +++ b/metaflow/runner/deployer.py @@ -25,6 +25,8 @@ def handle_timeout( Temporary file that stores runner attribute data. command_obj : CommandManager Command manager object that encapsulates the running command details. + file_read_timeout : int + Timeout for reading the file. Returns ------- From 9249b0f90a561cb3e83f57ad09eb38c48f2a998f Mon Sep 17 00:00:00 2001 From: Romain Cledat Date: Thu, 12 Sep 2024 00:54:58 -0700 Subject: [PATCH 3/3] Address comments --- metaflow/runner/deployer.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/metaflow/runner/deployer.py b/metaflow/runner/deployer.py index 3d161a1f139..cf704a5432f 100644 --- a/metaflow/runner/deployer.py +++ b/metaflow/runner/deployer.py @@ -399,7 +399,9 @@ def create(self, **kwargs) -> DeployedFlow: self.name = content.get("name") self.flow_name = content.get("flow_name") self.metadata = content.get("metadata") - self.additional_metadata = content.get("additional_metadata", {}) + # Additional info is used to pass additional deployer specific information. + # It is used in non-OSS deployers (extensions). + self.additional_info = content.get("additional_info", {}) if command_obj.process.returncode == 0: deployed_flow = DeployedFlow(deployer=self)