From 016aab048157da5666bc7acddad0a26643c39846 Mon Sep 17 00:00:00 2001 From: andrewdicken-stripe <89274571+andrewdicken-stripe@users.noreply.github.com> Date: Mon, 14 Aug 2023 08:47:20 -0700 Subject: [PATCH] Revert proxy change (#579) * Revert "Optionally pass in `proxy` parameter to Savon (#548)" This reverts commit 7490788417ff4789c3ea52ec018671110c112a83. * Restore history to state of master * Updates history with current change * Revert test file back to state of master * Random comment change to get another build * Reverting comment test --- HISTORY.md | 1 + lib/netsuite/configuration.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/HISTORY.md b/HISTORY.md index c7bcf7e0..f8f1ee65 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -3,6 +3,7 @@ ### Added ### Fixed +* Revert recent proxy changes which breaks proxy usage by @andrewdicken-stripe in https://github.com/NetSweet/netsuite/pull/579 ### Breaking Changes diff --git a/lib/netsuite/configuration.rb b/lib/netsuite/configuration.rb index 5f2b0950..91fe7025 100644 --- a/lib/netsuite/configuration.rb +++ b/lib/netsuite/configuration.rb @@ -32,8 +32,8 @@ def connection(params={}, credentials={}, soap_header_extra_info={}) logger: logger, log_level: log_level, log: !silent, # turn off logging entirely if configured + proxy: proxy, }.update(params)) - client.globals.proxy(proxy) if proxy cache_wsdl(client) return client end