Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinForms CultureInfo #170

Open
ghost opened this issue Mar 11, 2021 · 1 comment
Open

WinForms CultureInfo #170

ghost opened this issue Mar 11, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 11, 2021

Hi again!
I'm having an issue with Cultures and WinForms.
I have created a WinForms application with "Default" and "es-MX" culture.
Launching with "es-MX" culture by setting it inside Main.
NetSparkle doesn't shows up with the desired culture and as far as I can see in the resources it has been translated to "es-MX".

public static void Main(string[] args)
        {
            var culture = CultureInfo.GetCultureInfo("es-MX");
            CultureInfo.DefaultThreadCurrentCulture = culture;
            CultureInfo.DefaultThreadCurrentUICulture = culture;
            ...

image

Help would be appreciated.
Thanks.

@Deadpikle
Copy link
Collaborator

Hi @Kyberal,

Thanks for the bug report.

Localization support is not yet functional for v2.0 -- see #92. There is some limited localization support working that was carried over from the very old days, but I haven't done anything to get it working again for 2.0 with the WPF and Avalonia UIs, much less update it for the new 2.0 strings.

As you can see from this screenshot, there's still some left over, but even this window is not fully translated:

leftover-localization

You can technically override the UI with your own, but for now, multi-language support is missing/not working. Sorry for the unfortunate news.

If you'd like to contribute translations or work in this area, please feel free! There are some strings in src/NetSparkle/Properties/Resources.resx that need translating, and we'd have to refactor the message that's generated in the update availability window, too. (UpdateAvailableWindow). Then figure out how best to do this localization in WPF/Avalonia...

@Deadpikle Deadpikle added the bug label Mar 14, 2021
@Deadpikle Deadpikle added this to the 2.1+ milestone Mar 14, 2021
@Deadpikle Deadpikle modified the milestones: 2.2+, Future Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant