Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - make "branding" optional #145

Open
jugaltheshah opened this issue Apr 18, 2020 · 2 comments
Open

Feature request - make "branding" optional #145

jugaltheshah opened this issue Apr 18, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jugaltheshah
Copy link
Contributor

I wanted to open a discussion on the possibility of making the Shepherd "branding" during PR creation optional via env var / CLI option. The commit title in particular breaks things looking for semantic commit messages.

@aorinevo aorinevo added the enhancement New feature or request label Apr 18, 2020
@aorinevo
Copy link
Collaborator

aorinevo commented Apr 18, 2020

@jugaltheshah, I'm definitely on board with this. I'd be happy to review a PR for this, if you'd like to take this on.

Another thing to consider and potential for future work. I think we'll need to implement configuration management that goes beyond env vars. That is, allow users to configure the behavior of Shepherd via some config file, say .shepherdrc.json with prioritization given to values set in .shepherdrc.json over env vars.

ROI:

  • Persistence of configurations across terminal sessions
  • Retradable as a way to feature flag
  • Componentizes configuration management

(I'll open a separate issue for that)

@parshap
Copy link
Contributor

parshap commented Apr 18, 2020

I’m on board with that too. It might be good to just remove the prefix in Shepherd and rely on shepherd.yml specifying the title in full.

Agree with a better config system too. I wrote some thoughts on this here: #91

My vision is a unified “cascading” config system, where every option can either be set at a global level (e.g., ~/shepherd.yml), a migration file, or as command line options (with precedence working in that order too). I think a bifurcated system where there’s a separate set of “config” from migration options you set in shepherd.yml might make sense too, but I think it will be hard to predict what people will want to control globally vs on a per-migration basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants