Revert GC HACK #1464
Merged
Revert GC HACK #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 72ce576.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
+ Coverage 84.72% 86.56% +1.83%
==========================================
Files 110 113 +3
Lines 29364 35609 +6245
==========================================
+ Hits 24880 30826 +5946
- Misses 4484 4783 +299 ☔ View full report in Codecov by Sentry. |
lgoettgens
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 72ce576.
For now this will likely just result in the 1.10 CI tests failing. We should re-run the tests here once 1.10 has reverted those changes (I assumes that means 1.10-beta4 or 1.10-rc1 or so). I am mostly opening this PR now so that we won't forget later.