Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and Clean the Frame Class #23

Open
folliked opened this issue Oct 31, 2016 · 1 comment
Open

Improve and Clean the Frame Class #23

folliked opened this issue Oct 31, 2016 · 1 comment
Milestone

Comments

@folliked
Copy link
Contributor

folliked commented Oct 31, 2016

Currently, we use the Frame class to process and handle binary frames, and the non-binary object itself. Ideally, the binary should be processed in another class, that would process the binary data, and output a non-binary Frame object. This would ensure consistent methods and behavior within the Frame class, by processing data outside of it, then handling processed data to the class. (Thanks Pesticide <3)

@folliked folliked added this to the Improve and Clean the Frame Class milestone Oct 31, 2016
@Nek-
Copy link
Member

Nek- commented Nov 2, 2016

First tentative (unfinished, estimated done at 17%) in the following branch: refactor/split-frame-building.

Notice that a refactoring may break performance. We should be aware and carful with that fact.

Here are some leads:

  • The Messageclass is actually a Context pattern
  • The received data maybe should be considered as a stream of Frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants