Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OmniBridge]: Clarify accounts field #66

Open
frolvanya opened this issue Oct 9, 2024 · 0 comments
Open

[OmniBridge]: Clarify accounts field #66

frolvanya opened this issue Oct 9, 2024 · 0 comments

Comments

@frolvanya
Copy link
Contributor

pub accounts: Vec<(AccountId, bool)>,

// If storage is sufficient, then flag should be false, otherwise true
let sender_is_storage_deposit =
!utils::storage::is_storage_sufficient(jsonrpc_client, &token, &sender)
.await
.unwrap_or_default();
let recipient_is_storage_deposit =
!utils::storage::is_storage_sufficient(jsonrpc_client, &token, &recipient)
.await
.unwrap_or_default();

This is confusing, it's better to introduce enum for this

@frolvanya frolvanya changed the title Clarify accounts field [OmniBridge]: Clarify accounts field Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant