Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vidtonerf/ Frames Return Out Of Order #114 #6

Open
SimonDaKappa opened this issue Sep 9, 2024 · 1 comment · May be fixed by #15
Open

vidtonerf/ Frames Return Out Of Order #114 #6

SimonDaKappa opened this issue Sep 9, 2024 · 1 comment · May be fixed by #15
Labels
bug Something isn't working From VidToNerf good first issue Good for newcomers

Comments

@SimonDaKappa
Copy link
Collaborator

Copy from vidtonerf

During end-end testing, it's been discovered that all frames rendered are being returned to the front end, but they are sent out of order, at the moment, seemingly at random. Found out the order that frames are being sent in (perhaps the order they're being rendered in?) and set them up such that the rendered video returned to the front-end is being shown as it's meant to.

@SimonDaKappa SimonDaKappa added bug Something isn't working good first issue Good for newcomers labels Sep 9, 2024
@SimonDaKappa
Copy link
Collaborator Author

I believe aidan has fixed this, but it should be because the sfm worker passes a dict of file paths to sfm-out instead of list. Should probably be checked again however. Also, gaussian splatting .ply, .splat is resistant to frame ordering, but im not sure about video generation.
Video Generation for nerf-worker

@SimonDaKappa SimonDaKappa linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working From VidToNerf good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant