From 0c4b819941b0327e572772018298cf9cf181436e Mon Sep 17 00:00:00 2001 From: Eduardo Speroni Date: Fri, 4 Aug 2023 17:32:21 -0300 Subject: [PATCH] fix: don't suppress timer exceptions --- NativeScript/runtime/Timers.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/NativeScript/runtime/Timers.cpp b/NativeScript/runtime/Timers.cpp index f004a49f..6f0d189a 100644 --- a/NativeScript/runtime/Timers.cpp +++ b/NativeScript/runtime/Timers.cpp @@ -161,7 +161,6 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) { v8::Local cb = task->callback_.Get(isolate); v8::Local context = cb->GetCreationContextChecked(); Context::Scope context_scope(context); - TryCatch tc(isolate); auto argc = task->args_.get() == nullptr ? 0 : task->args_->size(); if (argc > 0) { Local argv[argc]; @@ -172,11 +171,11 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) { } else { (void)cb->Call(context, context->Global(), 0, nullptr); } - tc.ReThrow(); if (!task->repeats_) { data->state->removeTask(task); } + } void Timers::SetTimer(const v8::FunctionCallbackInfo& args, bool repeatable) {