Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleartext password in error log #119

Open
julupu opened this issue Mar 31, 2019 · 0 comments
Open

Cleartext password in error log #119

julupu opened this issue Mar 31, 2019 · 0 comments

Comments

@julupu
Copy link

julupu commented Mar 31, 2019

Hi,

so when you try to register an account and the e-mail validation fails, the attempt is logged (via the stacktrace) and the cleartext password can be seen both in the webinterface (manage -> exceptions) as well as the error log (/var/log/apache2/mellivora-error.log).

Leaking/logging passwords to an admin due to incorrect input should not happen, this should not show up in the stack trace.

[Sun Mar 31 20:09:29.834193 2019] [php7:notice] [pid 11051] [client 192.168.178.21:42436] Exception: Invalid Email in /srv/www/mellivora/include/email.inc.php:150\nStack trace:\n#0 /srv/www/mellivora/include/session.inc.php(450): validate_email('a@b')\n#1 /srv/www/mellivora/htdocs/actions/register.php(31): register_account('a@b', 'password', 'Admin', '83', NULL)\n#2 {main}, referer: http://192.168.178.23/register

Best regards,
Julian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants