Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitbounds Changes #154

Closed
chriswhong opened this issue Sep 25, 2017 · 2 comments
Closed

Fitbounds Changes #154

chriswhong opened this issue Sep 25, 2017 · 2 comments

Comments

@chriswhong
Copy link
Contributor

When the user clicks on a clickable layer, changing the route, the map does a fitBounds to the selected feature.

Likewise, when the user closes the information pane, the main map also does a fitBounds to the default view.

fitBounds should only happen when the app is loaded for the first time.

fitBounds should not happen when transitioning routes within the app.

@andycochran
Copy link
Contributor

@chriswhong Are you saying no route change should fitBounds? Or that only when closing the content area we should not fitBounds?

@chriswhong
Copy link
Contributor Author

I think we have the desired functionality via #187, fitbounds (with offset on large screens) when navigating to a non-index route, do nothing when navigating back to index. Closing

@ghost ghost removed the in progress label Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants