Jv/add comments likes #144

Vrbitko · 2022-11-08T20:50:50Z

Description

Added likes and comments models. Implemented tests and added func for admins to delete comment.

References

Fixes # (issue)

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

adding and removing of comments/likes checked manually by calling endpoints
implemented tests
remove comments on admin side not testes. Just created new method which calls already tested delete_data on Comments model.

Test Configuration:

Firmware version: locally run mongoDB 6.0.1, with python version 3.9
Os: MacOS Monterey 12.6

Checklist:

I have added a description of the change
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented on my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules
I have searched previous suggestions before making a new one, as mine may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

server/admins/utils.py

+            {
+                "error_status": True,
+                "success_status": False,
+                "exception": e
+            },


NVombat · 2022-11-23T23:14:53Z

server/admins/utils.py

+            {
+                "error_status": True,
+                "success_status": False,
+                "exception": e


Revealing the exception data can be a security threat - Better to not disclose exception data

NVombat · 2022-11-23T23:18:27Z

server/admins/utils.py

+        response.JsonResponse
+    """
+    try:
+        comment = request.query_params.get("comment")


Since you are expecting a query parameter, have you defined a URL to accept the delete_comment request? Django works on a model-template view basis so you will need to create a view for deleting comments in the views.py and add a URL path for it as well.

NVombat · 2022-11-23T23:33:48Z

server/mainapp/models.py

@@ -123,3 +123,183 @@ def fetch_data(self) -> response.JsonResponse:
            return docs

        raise DataFetchingError("There Are No Posts In The Database At This Moment")
+
+
+class Likes:


To receive the likes, a URL will need to be created along with a view. This will refer to the endpoint that accepts the like and performs the database functionality - It will also update the UI with an increment in the Like Number on the screen.

NVombat · 2022-11-23T23:34:28Z

server/mainapp/models.py

+            )
+
+    def delete_all_data(self) -> None:
+        """Delete all likes from db


This functionality should only be with the admin - Deleting the data should not be used by any ordinary developer

NVombat · 2022-11-23T23:36:39Z

server/admins/utils.py

@@ -12,7 +12,7 @@
    InvalidAdminIDError,
 )

-from . import Paginate, Music_Data, User_Data, Admin_Auth, Admin_Token_Auth
+from . import Paginate, Music_Data, User_Data, Admin_Auth, Admin_Token_Auth, Comments


These dot imports are from the init file - It does not seem like you have added a class so it can be imported

NVombat · 2022-11-23T23:41:42Z

server/mainapp/models.py

@@ -123,3 +123,183 @@ def fetch_data(self) -> response.JsonResponse:
            return docs

        raise DataFetchingError("There Are No Posts In The Database At This Moment")
+
+
+class Likes:


You can also add a Dislike option with the same functionality and use flags to decipher which one you are dealing with to prevent code repetition

NVombat · 2022-11-23T23:42:16Z

server/mainapp/models.py

+        raise DataFetchingError("There Are No Likes In The Database At This Moment")
+
+
+class Comments:


Similar to the likes - To receive the comments, a URL will need to be created along with a view. This will refer to the endpoint that accepts the comment and performs the database functionality - It will also update the UI with the comment for the client

NVombat · 2022-11-23T23:42:45Z

server/mainapp/models.py

+                f"Comment: \n{comment}\ndoes not exists."
+            )
+
+    def delete_all_data(self) -> None:


This functionality should be restricted to the admin only

NVombat · 2022-11-23T23:43:15Z

server/mainapp/models.py

+                """
+        self.db.remove()
+
+    def fetch_data(self) -> response.JsonResponse:


Another function can be created to fetch comments for a specific post as well

NVombat · 2022-11-23T23:44:30Z

server/mainapp/models.py

+        }
+        self.db.insert_one(data)
+
+    def delete_data(self, comment: str) -> None:


If the "comment" field represents the comment ID then where is the comment being stored and if not then the ID is not used or present.

NVombat · 2022-11-24T01:33:48Z

server/mainapp/models.py

@@ -123,3 +123,183 @@ def fetch_data(self) -> response.JsonResponse:
            return docs

        raise DataFetchingError("There Are No Posts In The Database At This Moment")
+
+
+class Likes:


Also, If you check the user profile, it has a list for contact_us query IDs. Similarly, you should create a list for likes and comments so that we can see which posts a user has liked and commented. This will make user analysis and function handling easier.

NVombat · 2022-11-24T01:35:34Z

server/mainapp/models.py

+            None
+        """
+
+        data = {


Maybe include a comment ID? I can only see a comment field - no ID has been created or stored. Prefix the ID with 'ct'
For example:

ct_153g2e3u0238e0uj

That is an example of the comment ID and like IDs can also be similar

youngSuggar added 5 commits November 8, 2022 19:42

feat: created models for likes and comments

12e4a72

feat: admin comment deletion

5129271

test: added tests for likes and comments

e95fcc6

test: updated tests

d462c02

feat: admin remove commment

9c72d7d

NVombat assigned Vrbitko Nov 8, 2022

NVombat linked an issue Nov 8, 2022 that may be closed by this pull request

Add Likes & Comments Option For Posts #111

Open

github-advanced-security bot found potential problems Nov 11, 2022

View reviewed changes

server/admins/utils.py

Comment on lines +168 to +172

{

"error_status": True,

"success_status": False,

"exception": e

},

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.

NVombat requested changes Nov 23, 2022

View reviewed changes

NVombat requested changes Nov 24, 2022

View reviewed changes

fix: admin init Comments

ca04028

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jv/add comments likes #144

Jv/add comments likes #144

Vrbitko commented Nov 8, 2022 •

edited by NVombat

Loading

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

Vrbitko Dec 6, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 23, 2022

NVombat Nov 24, 2022

NVombat Nov 24, 2022

		raise DataFetchingError("There Are No Likes In The Database At This Moment")


		class Comments:

Jv/add comments likes #144

Are you sure you want to change the base?

Jv/add comments likes #144

Conversation

Vrbitko commented Nov 8, 2022 • edited by NVombat Loading

Description

References

Type of change

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vrbitko commented Nov 8, 2022 •

edited by NVombat

Loading