Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from fetch to axios #125

Open
shvam0000 opened this issue Mar 12, 2022 · 2 comments
Open

Migrate from fetch to axios #125

shvam0000 opened this issue Mar 12, 2022 · 2 comments
Labels
cleanup Pull requests that cleanup code enhancement New feature or request frontend For frontend related issues good first issue Good for newcomers other Some other Issue

Comments

@shvam0000
Copy link
Collaborator

shvam0000 commented Mar 12, 2022 •
edited by NVombat
Loading

What would you like to share?

In the codebase, we have used fetch and Axios both for the API calls, we should efficiently have only one to be used uniformly across the codebase. So we need to migrate from fetch to Axios wherever found.
@shvam0000 shvam0000 added enhancement New feature or request other Some other Issue cleanup Pull requests that cleanup code frontend For frontend related issues labels Mar 12, 2022
@shvam0000 shvam0000 added the good first issue Good for newcomers label Mar 12, 2022
@1mehmood0
Copy link

Hey. I am new to open source and seeing the good first issue tag i am here. Will love to help .
Can you give this issue to me?

@NVombat
Copy link
Owner

NVombat commented Mar 15, 2022

Hey. I am new to open source and seeing the good first issue tag i am here. Will love to help . Can you give this issue to me?

Hey @1pervysage0 Thank you for showing interest in the issue. We would love to hand over this issue to you and I hope you have gone through the code because before we assign this issue to you I would like to ask if you have a decent understanding of how 'axios' works and how the client is functioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Pull requests that cleanup code enhancement New feature or request frontend For frontend related issues good first issue Good for newcomers other Some other Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@1mehmood0 @shvam0000 @NVombat