OAuth2.0 Implementation frontend ~ Mayank, Bhanu #120
Conversation
NVombat
changed the title
client/src/context/auth-context.js
Outdated
| let loginUser = async (e) => { | ||
| e.preventDefault(); | ||
| let response = await fetch( | ||
| 'http://127.0.0.1:8000/api/auth/generatetokens', |
There was a problem hiding this comment.
Can we change this API URL to the actual one? Try putting it in .env file and fetch it from there.
Please update the .env.example file as well if needed.
client/src/context/auth-context.js
Outdated
|
|
||
| let loginUser = async (e) => { | ||
| e.preventDefault(); | ||
| let response = await fetch( |
There was a problem hiding this comment.
Please change 'fetch' to 'axios'
There was a problem hiding this comment.
but we aren't using Axios, we are just using the fetch command to do it, I think changing it to Axios might break it! do we need to do it via using Axios interceptors
client/src/context/auth-context.js
Outdated
| setAuthTokens(data); | ||
| setUser(jwt_decode(data.access_token)); | ||
| localStorage.setItem('authTokens', JSON.stringify(data)); // here is the code that will be used to storedToken | ||
| history.push('/profile'); // this will send the user to the profile page the moment he logs in |
There was a problem hiding this comment.
Please use history.replace() method instead history.push().
client/src/context/auth-context.js
Outdated
| setAuthTokens(null); | ||
| setUser(null); | ||
| localStorage.removeItem('authTokens'); | ||
| history.push('/login'); |
There was a problem hiding this comment.
Please use history.replace() method instead history.push().
client/src/context/auth-context.js
Outdated
| clearTimeout(logoutTimer); | ||
| const updateToken = async () => { | ||
| let response = await fetch( | ||
| 'http://127.0.0.1:8000/api/auth/generatetokens', |
There was a problem hiding this comment.
Can we change this API URL to the actual one? Try putting it in .env file and fetch it from there.
Please update the .env.example file as well if needed.
client/src/context/auth-context.js
Outdated
| if (logoutTimer) { | ||
| clearTimeout(logoutTimer); | ||
| const updateToken = async () => { | ||
| let response = await fetch( |
There was a problem hiding this comment.
Please change 'fetch' to 'axios'
There was a problem hiding this comment.
but we aren't using Axios, we are just using the fetch command to do it, I think changing it to Axios might break it! do we need to do it via using Axios interceptors
client/src/context/auth-context.js
Outdated
| login: loginHandler, | ||
| logout: logoutHandler, | ||
| }; | ||
| let onehrs = 1000 * 60 * 60; |
There was a problem hiding this comment.
Please use camCasing for defining variables.
Description
Implemented OAuth2.0 on the frontend
References
Add any reference to previous pull-request or issue
Fixes #117
Type of change
Please delete options that are not relevant.