Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime Bug]: Taking a capture when a mesh is being drawn by the remixAPI will result in a crash #671

Open
xoxor4d opened this issue Nov 1, 2024 · 1 comment
Labels
bug Something isn't working jira A jira ticket exists runtime RTX Remix runtime

Comments

@xoxor4d
Copy link

xoxor4d commented Nov 1, 2024

Describe the bug

Taking a game capture when a mesh is being drawn by the remixApi will result in a crash in GameCapturer::captureMaterial.

It seems like the material of the api mesh is being interpreted as a LegacyMaterial and does not contain a valid
colorTexture pointer. Thus, materialData.getColorTexture().getImageView()->image() will access a nullptr and throw an assert:

https://github.com/NVIDIAGameWorks/dxvk-remix/blob/86269785f17a8151aea058bfbdb480d27bf2eaa9/src/dxvk/rtx_render/rtx_game_capturer.cpp#L493C31-L493C43

Screenshot 2024-10-30 143505

The meshes I've tried this with had no albedo texture assigned (simple emissive prims and rayportal's)

Note:

I've created a PR with a band-aid fix preventing api meshes from being captured:
NVIDIAGameWorks/dxvk-remix#82


How do you reproduce the bug?

  1. Create a material, a mesh and then draw it via the remixApi (only tested on x86 through the bridge)
  2. Take a game capture

What is the expected behavior?

Turning off replacements should also turn off meshes drawn via the api OR they should not be interpreted as legacy meshes

Version

latest

@NV-LL
Copy link
Collaborator

NV-LL commented Nov 7, 2024

REMIX-3696 for tracking

@NV-LL NV-LL added jira A jira ticket exists and removed triage labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira A jira ticket exists runtime RTX Remix runtime
Projects
None yet
Development

No branches or pull requests

2 participants