Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Recommend batch size bytes to 1GB #1399

Closed
kuhushukla opened this issue Oct 29, 2024 · 1 comment · Fixed by #1471
Closed

[BUG] Recommend batch size bytes to 1GB #1399

kuhushukla opened this issue Oct 29, 2024 · 1 comment · Fixed by #1471
Assignees
@parthosa
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@kuhushukla
Copy link
Collaborator

Describe the bug
Currently we try and recommend a batch size that could be more than the 1GB value which seems to work best for most customers. We should default to this for now at least for the first GPU run (when profiler runs on CPU logs)
@kuhushukla kuhushukla added ? - Needs Triage bug Something isn't working labels Oct 29, 2024
@amahussein amahussein added the core_tools Scope the core module (scala) label Nov 1, 2024
@mattahrens
Copy link
Collaborator

Scope: update auto-tuner to detect that it is processing a CPU event log and then default batch size bytes to 1GB. When GPU event log is detected, we can keep default as 2GB.

@parthosa parthosa self-assigned this Dec 12, 2024
@parthosa parthosa mentioned this issue Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
4 participants
@mattahrens @parthosa @kuhushukla @amahussein