Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc build CI might update too frequently #351

Open
leofang opened this issue Jan 4, 2025 · 3 comments
Open

Doc build CI might update too frequently #351

leofang opened this issue Jan 4, 2025 · 3 comments
Assignees
Labels
CI/CD CI/CD infrastructure P1 Medium priority - Should do

Comments

@leofang
Copy link
Member

leofang commented Jan 4, 2025

Since we merged #325 yesterday, the latest doc has been rebuilt several times. Taking the latest commit 8e4e4f2 as example, we see the gh-pages branch was updated frequently for two reasons:

  1. The Jupyter notebook hash is different in every run
  2. The environment.pickle doctrees generated by Sphinx are checked in
    • Q: Can we remove them from the artifacts?
@github-actions github-actions bot added the triage Needs the team's attention label Jan 4, 2025
@leofang
Copy link
Member Author

leofang commented Jan 4, 2025

  1. The environment.pickle doctrees generated by Sphinx are checked in

    • Q: Can we remove them from the artifacts?

Related discussion: materialsproject/atomate2#345. Looks like the answer is yes.

Previously @trxcllnt and I had some conversation about binary blobs being checked in could cause git checkout slowness (it was for a different context). Perhaps Paul might have some tips for how to properly address this? 😉

@leofang
Copy link
Member Author

leofang commented Jan 4, 2025

On the pickle files: It seems to be my overlook in #183 because previously @vzhurba01 seems to be careful enough to not check them in? @vzhurba01 did your purge the pickle files before pushing?

@leofang leofang added the CI/CD CI/CD infrastructure label Jan 5, 2025
@leofang leofang added P1 Medium priority - Should do and removed triage Needs the team's attention labels Jan 12, 2025
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

The Jupyter notebook hash is different in every run

@vzhurba01 could you check if changing this from force to cache would be enough to stop updating the hash?

jupyter_execute_notebooks = "force"

Otherwise, we should set it to off or find another way (ex: just don't check in the Jupyter notebook to the gh-pages branch).

xref: https://myst-nb.readthedocs.io/en/v0.10.1/use/execute.html#triggering-notebook-execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure P1 Medium priority - Should do
Projects
None yet
Development

No branches or pull requests

2 participants