Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading items_per_thread tuning parameter for select #3587

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernhardmgruber
Copy link
Contributor

No description provided.

Copy link

copy-pr-bot bot commented Jan 29, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@gevtushenko
Copy link
Collaborator

I'd approach this differently. Instead of renaiming the macro, I'd remove the items scaling in the places where it's used. This would make the encoding easier and help search process have finar granularity on each parameter.

@bernhardmgruber
Copy link
Contributor Author

I'd approach this differently. Instead of renaiming the macro, I'd remove the items scaling in the places where it's used. This would make the encoding easier and help search process have finar granularity on each parameter.

I wondered about this myself. Alright, let's change this when we are done merging all tunings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants