Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common class for aligner models #272

Open
gshennvm opened this issue Aug 27, 2024 · 0 comments
Open

common class for aligner models #272

gshennvm opened this issue Aug 27, 2024 · 0 comments

Comments

@gshennvm
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Many different classes in aligner have similar implementations that are duplicated. For example log prob calculation in DPO and PPO get log prob. Instead we should create a common class or common until function to avoid this duplication.

in complicated cases like with TRT-LLM this is even more important since there are various edge cases that should be handled centrally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant