New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better add_BOS and add_EOS support in reward models #231

Open

gshennvm opened this issue Jul 10, 2024 · 0 comments

Collaborator

gshennvm commented Jul 10, 2024

currently:

serve_reward_model hardcodes both BOS & EOS to False

RewardModelDataset allows adding EOS (but not BOS)

and once #219 gets merged the infer will allow users to pass both.

I think we should unify and allow add_BOS/add_EOS to be everywhere, or just remove it and hard code it all to False

gshennvm mentioned this issue

critic speedup #219

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment