-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job launcher #3049
Job launcher #3049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to use event to select launchers, as we discussed before. This will make our core code completely free of launcher specific knowledge (e.g. image).
Define a set of standard return codes for the "poll" method.
No need for "can_launch" method in Launcher Spec.
See comments for detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite there yet:
- The return code of poll() should be standardized.
- The condition for checking job_launcher isn't right.
- See other comments for improvement in other areas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. See my comments for return code improvement that can be done in another PR.
Also need another PR to modify job_meta_validator.py to support the new deploy_map format.
/build |
/build |
/build |
/build |
/build |
Fixes # .
Description
Added the job launcher API. Each site will have the ability to choose how to launch the job to run. Currently only support the client side job launch. There are 2 launchers to choose from, ProcessJobLauncher, or K8sJobLauncher. The job launcher is configured in the local/resources.json components like this:
Types of changes
./runtest.sh
.