Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fedrag example with embedding training #2915

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ZiyueXu77
Copy link
Collaborator

Description

Add example folder for FedRAG, first example is added for embedding model training

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77 ZiyueXu77 marked this pull request as draft September 5, 2024 18:00
@ZiyueXu77
Copy link
Collaborator Author

Fully functional, but with job template, to add python execution

@ZiyueXu77
Copy link
Collaborator Author

to use FedJob API, need updates to https://github.com/NVIDIA/NVFlare/blob/main/nvflare/app_opt/pt/job_config/model.py to enable persistor args, save for later

@ZiyueXu77 ZiyueXu77 marked this pull request as ready for review September 5, 2024 19:03
@SYangster
Copy link
Collaborator

to use FedJob API, need updates to https://github.com/NVIDIA/NVFlare/blob/main/nvflare/app_opt/pt/job_config/model.py to enable persistor args, save for later

You can also add the persistor explicitly to the job with the args you need. The PTModel is just a wrapper for convenience.

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great examples, added some suggestions

examples/advanced/rag/embedding/README.md Outdated Show resolved Hide resolved
examples/advanced/rag/generation/README.md Outdated Show resolved Hide resolved
examples/advanced/rag/embedding/README.md Outdated Show resolved Hide resolved
@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77
Copy link
Collaborator Author

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants