Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] nvflare config does not allow @ sign in directory #2602

Closed
dirkpetersen opened this issue May 28, 2024 · 2 comments
Closed

[BUG] nvflare config does not allow @ sign in directory #2602

dirkpetersen opened this issue May 28, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dirkpetersen
Copy link
Contributor

dirkpetersen commented May 28, 2024

Describe the bug

If I run nvflare config and point it to the unzipped location of my console, I get this error:

nvflare config -d ~/.nvflare/myproject/[email protected] --job_templates_dir ~/NVFlare/job_templates/

Unable to handle command: config due to: Expected '}', found '@'  (at char 90), (line:3, col:59)

If I download the console from the dashboard it will be stored as [email protected] so the unzipped folder will likely always have an @ sign in the folder name.

This should also work with an + sign in the email [email protected] as + works as a suffix that allows people to create multiple identities but work with the same email address.

@dirkpetersen dirkpetersen added the bug Something isn't working label May 28, 2024
@chesterxgchen
Copy link
Collaborator

@dirkpetersen thanks for reporting. there is no special characters treatment right now. We are using Pyhocon parser to parse. We have to see what we need to do in order to support special characters.

@chesterxgchen chesterxgchen mentioned this issue Jun 3, 2024
6 tasks
@chesterxgchen
Copy link
Collaborator

This is turn out to be an simple fix, we just need to quote the string for the pyhocon parser. I fix it in this PR:
#2607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants