Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add a find_peaks function #603

Open
cliffburdick opened this issue Apr 4, 2024 · 1 comment
Open

[FEA] Add a find_peaks function #603

cliffburdick opened this issue Apr 4, 2024 · 1 comment

Comments

@cliffburdick
Copy link
Collaborator

find_peaks is a useful function for giving the user a powerful interface to find one or more peaks in a signal based on some criteria. The SciPy find_peaks has many features, some of which aren't used as much. This issue is for implementing an MVP of this function with the distance, threshold, and height parameters.

https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.find_peaks.html

@deanljohnson
Copy link

I would be very interested in a well optimized 2d version of this function.

I have implemented something previously, but I really doubt it is optimal. I used cub::DeviceSelect::Flagged with a custom iterator that returned true if an index was a local optima (by checking all adjacent values). It would not support a distance parameter, but could handle the threshold and height parameters easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants