-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HostIR integration to FusionExecutorCache PR 1/n #3707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarka
force-pushed
the
nsarka/hostir-integration
branch
from
January 14, 2025 18:01
94b4d48
to
5852eb7
Compare
wujingyue
reviewed
Jan 14, 2025
Thanks, updated. |
wujingyue
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
nsarka
force-pushed
the
nsarka/hostir-integration
branch
from
January 14, 2025 21:13
581d0c9
to
4409faa
Compare
!test |
nsarka
force-pushed
the
nsarka/hostir-integration
branch
from
January 14, 2025 21:32
2590d88
to
bab9bff
Compare
wujingyue
reviewed
Jan 14, 2025
nsarka
force-pushed
the
nsarka/hostir-integration
branch
from
January 15, 2025 14:59
ae9f1ac
to
a14c4ea
Compare
wujingyue
approved these changes
Jan 15, 2025
wujingyue
reviewed
Jan 15, 2025
!test |
so cloning automatically works without a cloning constructor.
!test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add a vector of KernelExecutor* to HostIrContainer, and new HostIR called LaunchKernel that takes an index to the vector and launches the kernel. I also add a test to verify correctness.
This is the first in a series of PRs for integration with FusionExecutorCache.