Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of small fixes and Vulkan features #61

Open
GaelCathelin opened this issue Jan 10, 2025 · 1 comment
Open

A bunch of small fixes and Vulkan features #61

GaelCathelin opened this issue Jan 10, 2025 · 1 comment

Comments

@GaelCathelin
Copy link
Contributor

Hello! First of all thank you so much for this wonderful abstraction, it makes my life so much easier.

I've been using it as the main building block of a Vulkan abstraction (I don't use the DX backends at all) for more than a year and I wanted to share some fixes and small features that I did on the Vulkan backend: https://github.com/GaelCathelin/nvrhi/commits/main?author=GaelCathelin

If you're interested, let me know if you want one or several pull requests.

On the experimental branch there are more commits (the 4 on the top the list) that are likely incompatible with the other backends but they fixed some roadblocks that I had while implementing automatic BindingSets generation with shader reflections on top of NVRHI, and I'm not 100% confident that I did the right thing.

@apanteleev
Copy link
Collaborator

Thank you for the offer!

If you could submit your changes as multiple PRs (one per feature, or maybe grouping some closely related features together), that would be great. But before that, please minimize the diffs by reverting any whitespace-only changes, and make the new features work on all graphics APIs where possible/applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants