Skip to content

Commit dbb7af7

Browse files
committed
use tox tmpdir to install distributed-embeddings
1 parent 8c2e0e6 commit dbb7af7

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

.github/workflows/cpu-horovod.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ jobs:
3737
- name: Install tox-conda
3838
run: |
3939
python -m pip install tox-conda
40-
- name: Prepare distributing-embeddings installation
41-
uses: actions/checkout@v3
42-
with:
43-
repository: NVIDIA-Merlin/distributed-embeddings
44-
path: /tmp/distributed-embeddings
4540
- name: Run tests
4641
run: |
4742
ref_type=${{ github.ref_type }}

examples/usecases/multi-gpu/install_distributed_embeddings.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22

33
set -e
44

5+
INSTALL_DIR=$1
6+
57
WORK_DIR=$(pwd)
6-
ROOT_DIR="/tmp"
78

8-
cd $ROOT_DIR
9+
cd $INSTALL_DIR
910

1011
if [ ! -d "distributed-embeddings" ]; then
1112
git clone https://github.com/NVIDIA-Merlin/distributed-embeddings.git

tox.ini

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ commands =
2828
; Runs in: Github Actions
2929
; Runs GPU-based tests.
3030
allowlist_externals =
31-
sh
3231
horovodrun
33-
examples/usecases/multi-gpu/install_distributed_embeddings.sh
3432
deps =
3533
-rrequirements/test.txt
3634
passenv =
@@ -43,12 +41,12 @@ commands =
4341
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/core.git@{posargs:main}
4442
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/dataloader.git@{posargs:main}
4543
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/nvtabular.git@{posargs:main}
46-
# Install distributed embeddings and check build
47-
sh examples/usecases/multi-gpu/install_distributed_embeddings.sh
4844
# Run multi-gpu tests marked with `horovod` marker
4945
horovodrun -np 2 sh examples/usecases/multi-gpu/hvd_wrapper.sh pytest -m horovod -rxs tests/unit
5046

5147
[testenv:py38-horovod-cpu]
48+
allowlist_externals =
49+
bash
5250
setenv =
5351
HOROVOD_WITH_MPI=1
5452
HOROVOD_WITH_TENSORFLOW=1
@@ -61,7 +59,7 @@ commands =
6159
{envdir}/env/bin/python -m pip install horovod --no-cache-dir
6260
{envdir}/env/bin/horovodrun --check-build
6361
# Install distributed embeddings and check build
64-
sh examples/usecases/multi-gpu/install_distributed_embeddings.sh
62+
bash examples/usecases/multi-gpu/install_distributed_embeddings.sh {envtmpdir}
6563
# Install Merlin packages
6664
{envdir}/env/bin/python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/core.git
6765
{envdir}/env/bin/python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/dataloader.git

0 commit comments

Comments
 (0)