Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include error message in pipeline output when source_info is missing #65

Open
ashsong-nv opened this issue Jan 24, 2025 · 2 comments
Open
Labels
enhancement New feature or request P0

Comments

@ashsong-nv
Copy link
Collaborator

Currently there is no validation on whether the input message contains source info. When there is no source info, the agent is only able to use the internet search tool, which severely degrades the output. There are no warnings about the degraded output in the output JSON or markdown report, which can cause confusion and misleading accuracy results.

We should handle missing source info with one of the following options:

  1. Add pydantic validation and return an error upfront so the message is skipped altogether
  2. Continue to collect intel, and run the VulnerableDependencyChecker, but skip agent processing and include a warning message in the output
  3. Run full pipeline with agent, but include a warning message in the output

Optionally, make this a user configurable option.

@ashsong-nv
Copy link
Collaborator Author

One benefit of option 2 is that some users might find it valuable to still have the intel gathering and SBOM checking functionality. Needs product decision/prioritization.

@ashsong-nv ashsong-nv added the enhancement New feature or request label Jan 24, 2025
@ashsong-nv ashsong-nv added the P1 label Feb 14, 2025
@ashsong-nv
Copy link
Collaborator Author

We recently merged #76 that adds error handling for git clone failures and allows the pipeline to proceed. This can also result in the same issue as above.

Solution 1 with Pydantic validation won't address this case, so solution 2 seems most promising to cover both cases.

@Salonijain27 Salonijain27 added P2 and removed P2 labels Feb 14, 2025
@ashsong-nv ashsong-nv added P0 and removed P1 labels Mar 6, 2025
@ashsong-nv ashsong-nv changed the title Handle input messages with missing source_info Include error message in pipeline output when source_info is missing Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0
Projects
None yet
Development

No branches or pull requests

2 participants