Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use GH in the ring with 2FA. #115

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

danielballan
Copy link
Contributor

No description provided.

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some improvements of the text to avoid a possible leak of the token in a plain text form.

source/components/github.rst Outdated Show resolved Hide resolved
source/components/github.rst Outdated Show resolved Hide resolved
source/components/github.rst Outdated Show resolved Hide resolved
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a couple of corrections. Otherwise looks good.

source/components/github.rst Outdated Show resolved Hide resolved
source/components/github.rst Outdated Show resolved Hide resolved

$ git remote set-url <NAME> <NEW_URL>

For use inside the ring, connecting via SSH does not work. (Consult ITC to ask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intended?

Suggested change
For use inside the ring, connecting via SSH does not work. (Consult ITC to ask
For users inside the ring, connecting via SSH does not work. (Consult ITC to ask

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair question. I meant "use". Maybe it could be phrase more clearly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, don't put users inside the ring, it's not safe there 🤣.

Maybe we can better say "For use in the controls network ..."?

@cowanml
Copy link
Member

cowanml commented Jul 5, 2019 via email

@tacaswell
Copy link
Member

export GIT_SSH='ssh -o "ProxyCommand ssh -W %h:%p ssh01

Won't this push all ssh traffic, including to other machines on the floor through the proxy?

@cowanml
Copy link
Member

cowanml commented Jul 6, 2019 via email

danielballan and others added 2 commits July 8, 2019 09:31
Co-Authored-By: Leo Fang <[email protected]>
Co-Authored-By: Maksim Rakitin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants