Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update align.m1pit #7

Open
ambarb opened this issue Jul 22, 2018 · 4 comments
Open

update align.m1pit #7

ambarb opened this issue Jul 22, 2018 · 4 comments

Comments

@ambarb
Copy link
Contributor

ambarb commented Jul 22, 2018

Add exception so that yag will be pulled out unless the plan is halted.

Change plan so that yag is always retracted after scan is complete. Users are getting confused.
CUrrently, the final position of the m3diag is the initial position of the m3diag.

I understand why it was done this way, this is a hard one for the users to remember on top of all the other things. Staff will just have a 5 second window to RE.halt() if they want the YAG to stay in place.

@awalter-bnl
Copy link
Contributor

This is simple enough to do, I will look at it as soon as @ambarb or @bisogni let me know it is fine to do.

@ambarb
Copy link
Contributor Author

ambarb commented Aug 5, 2018

@bisogni pointed out that for the m3 alignment, we need to have the gc_diag stay where it is so maybe it is best to have an optional argument? For instance, return_2_out = False would put the diagnostic in the orginal postion at the start of the scan. Or maybe after_scan = 'out'

@ambarb
Copy link
Contributor Author

ambarb commented Aug 5, 2018

@awalter-bnl we haven't had a chance to organize out thoughts coherently so that we have a punch list of things for the shutdown.

@awalter-bnl
Copy link
Contributor

@ambarb, @bisogni no problem, so far I have not seen anything that I shouldn't be able to get done in the shutdown (depending on the workload form the bluesky/ophyd update release which this time around is only , medium level bug fixes with no major additions).

FYI I am away on vacation from August 10th to August 21st.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants