Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bluesky-darkframes #14

Open
mrakitin opened this issue May 19, 2020 · 2 comments
Open

Use bluesky-darkframes #14

mrakitin opened this issue May 19, 2020 · 2 comments
Assignees

Comments

@mrakitin
Copy link
Member

We need to convert the prototype of the code which inspired the bluesky-darkframes library to actually use it:

@mrakitin
Copy link
Member Author

May need @danielballan's support for that. We discussed using it with @elistavitski and @lcdesilva today during a call, and agreed it should be a long-term solution replacing the upcoming open/close run changes in https://github.com/NSLS-II-QAS/profile_collection/blob/pe_tests_local/startup/83-pe-plans-local.py once we are allowed onsite and have a beam to test the dark frames subtraction with photons.

@jklynch
Copy link

jklynch commented May 20, 2020

I worked on this with Chanaka. We did get bluesky-darkframes integrated but decided to stay with the code Chanaka has already written, just move it to an ophyd class so it works with count. This is a good opportunity for me and Chanaka to learn to write an ophyd class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants