You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That bit below defines CMAKE_CXX_STANDARD twice (and it does it globally... which is frowned upon). The CMAKE_C_COMPILER block is super strange and should be removed. The projectcommand should use the LANGUAGES CXX which would take care of linking to a C++ std lib, and defining the C/CXX compilers as needed.
Generally speaking, the project could benefit from a deep cleaning and modernization of the CMake config (eg: avoid polluting the global space and use target specific compilation flags). I know that's probably not a priority and not a sexy task, just saying.
Additional context
I noticed some issues while trying to build EnergyPlus with clang-17 on macOS M1.
The text was updated successfully, but these errors were encountered:
Describe the bug
This should never be done like this:
ssc/ssc/CMakeLists.txt
Line 253 in 9d76d0c
Please remove the
lstdc++
. Side note but the rest is also supoptimal:CMAKE_DL_LIBS
That bit below defines CMAKE_CXX_STANDARD twice (and it does it globally... which is frowned upon). The CMAKE_C_COMPILER block is super strange and should be removed. The
project
command should use theLANGUAGES CXX
which would take care of linking to a C++ std lib, and defining the C/CXX compilers as needed.ssc/CMakeLists.txt
Lines 28 to 48 in 9d76d0c
Generally speaking, the project could benefit from a deep cleaning and modernization of the CMake config (eg: avoid polluting the global space and use target specific compilation flags). I know that's probably not a priority and not a sexy task, just saying.
Additional context
I noticed some issues while trying to build EnergyPlus with clang-17 on macOS M1.
The text was updated successfully, but these errors were encountered: