Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelFlorisModel updated to match FlorisModel API #971

Open
5 tasks
paulf81 opened this issue Aug 22, 2024 · 0 comments
Open
5 tasks

ParallelFlorisModel updated to match FlorisModel API #971

paulf81 opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@paulf81
Copy link
Collaborator

paulf81 commented Aug 22, 2024

ParallelFlorisModel updated to match FlorisModel API

ParallelFlorisModel currently has an API not exactly 1-1 with FlorisModel. This may be necessary, for example in order to defer certain calculations until splitting onto cores, however ideally the variance will be minimized as much as possible. This issue is a placeholder to hold the intention to do some improvements in this vane and more generally.

Proposed solution

  • Provide default values to max_workers and n_wind_condition_splits based on detection of available cores
  • Remove unsupported parallel computing interfaces, perhaps standardize on one?
  • Make sure all control vectors are supported, not just yaw
  • Remove no_wake flags in favor of run, run_no_wake style of v4
  • Match as close as possible FlorisModel interface

Additional context

A small subset of improvements was added in #967

@paulf81 paulf81 added the enhancement An improvement of an existing feature label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants