From 83e16d4ff20ae859c497e5bac11e5ae7434d0e23 Mon Sep 17 00:00:00 2001 From: Michael O'Keefe Date: Mon, 9 Dec 2024 14:14:06 -0600 Subject: [PATCH] Add note for os matrix The Mac OS options might be hard for others to follow. Here, we add a note to help others following behind to understand what we're doing and why. --- .github/workflows/build_and_test.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml index 8f3db66e..8714e3ab 100644 --- a/.github/workflows/build_and_test.yaml +++ b/.github/workflows/build_and_test.yaml @@ -7,6 +7,9 @@ jobs: name: build py3.${{ matrix.python-version }} on ${{ matrix.platform || matrix.os.base }}-${{ matrix.os.version }} strategy: fail-fast: true + # NOTE: In the matrix below, we call out macos 13 and 14 explicitly. This is to enable running on both Intel and Apple Silicon for Mac. + # As of this writing, MacOS 13 is Intel and MacOS 14 is Apple Silicon. Ideally, the Apple transition to their new chip occurs fast and + # we can drop macos-13 checks and then just use 'latest'. matrix: os: - base: ubuntu