From 4abf4a9b85ae5ce639791f9d8aca1d37bd87589e Mon Sep 17 00:00:00 2001 From: Michael O'Keefe Date: Thu, 14 Nov 2024 14:52:29 -0700 Subject: [PATCH] Skipping speed tests. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These did not consistently pass on the CI. From Chad Baker: ... the speedup failing tests can be ignored for now. We need to come up with a better way of testing the speed up relative to fastsim-2, but I’m not sure that's an urgent problem. --- python/fastsim/tests/test_speedup.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/fastsim/tests/test_speedup.py b/python/fastsim/tests/test_speedup.py index c3020b59..c00db008 100644 --- a/python/fastsim/tests/test_speedup.py +++ b/python/fastsim/tests/test_speedup.py @@ -1,9 +1,11 @@ import time import numpy as np import fastsim as fsim +import pytest n_iters = 5 +@pytest.mark.skip(reason = "Ignoring for now") def test_hev_speedup(): # minimum allowed f3 / f2 speed ratio min_speed_ratio_si_none = 2 @@ -71,6 +73,7 @@ def test_hev_speedup(): assert t_fsim2_median / t_fsim3_no_save_median > min_speed_ratio_si_none, \ f"`min_speed_ratio_si_none`: {min_speed_ratio_si_none:.3G}, median achieved ratio: {(t_fsim2_median / t_fsim3_no_save_median):.3G}" +@pytest.mark.skip(reason = "Ignoring for now") def test_conv_speedup(): # minimum allowed f3 / f2 speed ratio # there is some wiggle room on these but we're trying to get 10x speedup