-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supercede run_analysis.rb
with buildstock_local
#372
Comments
I assume it's the python equivalent of something like this?
|
From @joseph-robertson : Some potential features or benefits to run_analysis.rb
|
@nmerket On the first (checked) item above, I'm confused. Something was changed/updated in buildstockbatch such that you can now use |
No, |
@nmerket |
Yes, but there are a lot of dependencies in buildstockbatch. Several have compiled components. If it's anything like how ruby is shipped with openstudio, I'm dubious that we'll ever be able to run buildstockbatch from openstudio. |
Ah, right. So that means running |
What's the value of being able to run buildstockbatch from openstudio? Not having to setup buildstockbatch separately? |
Yes. From my perspective, with |
To draw a parallel, the user can run
Plus there are fewer things that can go wrong -- wrong version of ruby, trouble compiling gems, etc. (And they already have openstudio since it's needed to run the simulations.) |
How did getting nokogiri installed with openstudio go? Now imagine that with numpy, pandas, dask, pyarrow, lxml, s3fs, boto3, and more. Unless openstudio comes with a fully functional pip package manager (it might for all I know), we'd either need to preload that full stack of libraries in openstudio or rewrite buildstockbatch from scratch with only modules in the standard library. I'm not sure that's feasible or even possible. There's several things that buildstockbatch does that run_analysis.rb doesn't do, most notably timeseries aggregation, that depend heavily on those libraries. |
I don't quite understand how openstudio handles package dependencies. For the case of ruby, @shorowit you said using openstudio directly means the user doesn't have to install any gems. Is the assumption there that the script is only using the gems that comes preinstalled with openstudio? And I presume same is the case with python where python and some set of packages are shipped with openstudio? |
Probably getting into @kbenne's territory here. |
Yes, openstudio comes preinstalled with various gems (run Support for python in openstudio is pretty new. I think it only comes with the standard library today; I don't know what the longer term plans are. |
Is your feature request related to a problem? Please describe.
See #349 for some context.
Describe the solution you'd like
The
buildstock_local
utility to have all the features ofrun_analysis.rb
that are nice to have. For example, the ability to run only sets of specified building IDs.It also appears that the
buildstock_local
utility requires that you update your path env var to point to the correct version of openstudio. Idea from @shorowit: Since the OS CLI now supports python, maybe bsb could be updated so that if you useopenstudio buildstock_local ...
instead ofpython buildstock_local
, it's smart enough to use that openstudio.Goals
Adopt
buildstock_local
in place ofrun_analysis.rb
- it's "official" and means a whole lot less code to maintain in the resstock repo.The text was updated successfully, but these errors were encountered: