Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEC PV module file has a duplicate entry #989

Closed
kandersolar opened this issue Mar 24, 2022 · 0 comments · Fixed by #1057
Closed

CEC PV module file has a duplicate entry #989

kandersolar opened this issue Mar 24, 2022 · 0 comments · Fixed by #1057
Assignees
@cpaulgilman
Labels
bug
Milestone
2021.12.02 Patch 2

Comments

@kandersolar
Copy link
Member

Describe the bug

The Silfab Solar Inc. SIL370MT-W module has two identical entries in the CEC module file currently on the patch branch.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://raw.githubusercontent.com/NREL/SAM/patch/deploy/libraries/CEC%20Modules.csv
  2. Ctrl-F Silfab Solar Inc. SIL370MT-W
  3. Observe the two identical rows

Expected behavior

No duplicates?

Screenshots

N/A

Operating System and Version

N/A

Additional context

I noticed this while updating pvlib with the latest SAM tables in pvlib/pvlib-python#1433
@cpaulgilman cpaulgilman self-assigned this Apr 12, 2022
@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Apr 12, 2022
@cpaulgilman cpaulgilman mentioned this issue May 30, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpaulgilman cpaulgilman

Labels
bug
Projects
None yet
Milestone
2021.12.02 Patch 2
Development

Successfully merging a pull request may close this issue.

Update CEC library files NREL/SAM
2 participants
@cpaulgilman @kandersolar