-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example scripts and docs #153
Comments
Can I add one example to the list? [ ] A water heater equipment example where all the conditions (ambient temp, ambient humidity (for HPWH), mains temp, and flow rate) are all in a data file. We have something kind of like this for running UEF tests in the pcm branch, although a lot of the conditions other than flow are constant so not in a file. Having this all be a file would be nice not just for running tests like UEF/FHR in OCHRE, but if you want to validate a WH model against real data from the lab or field this'd be really handy. A long time ago I had a script like this for HPWH model validation, but I think this is the closest thing we have recently (and using UEF test as the example probably makes the most sense anyways): https://github.com/NREL/OCHRE/blob/pcm-13node/bin/run_pcm_wh.py. We'd ideally just change the constant schedules to load from a csv of conditions, for this test they're constant anyways but that won't always be the case. |
I added that, and another example using CTA-2045 commands. Most new examples are in there now. |
Awesome, thanks Michael! This'll be really useful for a lot of future projects, and any time we want to validate a WH model (with or without controls) |
Addresses #153 - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script - [x] Update documentation as appropriate - [x] Update changelog as appropriate
There's a few issues related to example code (in bin/ and notebook/ folders) and docs that would be good to fix to improve accessibility:
The text was updated successfully, but these errors were encountered: