Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThermalStorage:Ice:Simple uses incorrect fluid property in calculation of Delta T #10890

Open
3 tasks
rraustad opened this issue Jan 9, 2025 · 0 comments
Open
3 tasks
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@rraustad
Copy link
Contributor

rraustad commented Jan 9, 2025

Issue overview

Code review shows an incorrect use of density where specific heat should be used. In function:

SimpleIceStorageData::CalcIceStorageDischarge

    Real64 CpFluid = FluidProperties::GetDensityGlycol(state,
                                                       state.dataPlnt->PlantLoop(loopNum).FluidName,
                                                       state.dataLoopNodes->Node(this->PltInletNodeNum).Temp,
                                                       state.dataPlnt->PlantLoop(loopNum).FluidIndex,
                                                       RoutineName);

Real64 DeltaTemp = Qice / CpFluid / this->ITSMassFlowRate;

See https://github.com/NREL/EnergyPlus/pull/10872/files#r1908950420

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to EnergyPlus Defect Complexity (Github Project)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Jan 9, 2025
Myoldmopar added a commit that referenced this issue Jan 10, 2025
Fix Issue #10890 Discovered During FluidAPI Refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

No branches or pull requests

1 participant