We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review shows an incorrect use of density where specific heat should be used. In function:
SimpleIceStorageData::CalcIceStorageDischarge
Real64 CpFluid = FluidProperties::GetDensityGlycol(state, state.dataPlnt->PlantLoop(loopNum).FluidName, state.dataLoopNodes->Node(this->PltInletNodeNum).Temp, state.dataPlnt->PlantLoop(loopNum).FluidIndex, RoutineName); Real64 DeltaTemp = Qice / CpFluid / this->ITSMassFlowRate;
See https://github.com/NREL/EnergyPlus/pull/10872/files#r1908950420
Some additional details for this issue (if relevant):
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
The text was updated successfully, but these errors were encountered:
Merge pull request #10892 from NREL/IceStorageFix
d14291c
Fix Issue #10890 Discovered During FluidAPI Refactor
No branches or pull requests
Issue overview
Code review shows an incorrect use of density where specific heat should be used. In function:
SimpleIceStorageData::CalcIceStorageDischarge
See https://github.com/NREL/EnergyPlus/pull/10872/files#r1908950420
Details
Some additional details for this issue (if relevant):
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
The text was updated successfully, but these errors were encountered: