Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:callbacks → :callback for newer DiffEqBase versions #316

Open
Alexsp32 opened this issue Nov 13, 2023 · 1 comment
Open

:callbacks → :callback for newer DiffEqBase versions #316

Alexsp32 opened this issue Nov 13, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Alexsp32
Copy link
Member

DiffEq complains about the way callbacks are passed to the solvers:

┌ Warning: Unrecognized keyword arguments found. Future versions will error.
│ The only allowed keyword arguments to `solve` are:
│ (:dense, :saveat, :save_idxs, :tstops, :tspan, :d_discontinuities, :save_everystep, :save_on, :save_start, :save_end, :initialize_save, :adaptive, :abstol, :reltol, :dt, :dtmax, :dtmin, :force_dtmin, :internalnorm, :controller, :gamma, :beta1, :beta2, :qmax, :qmin, :qsteady_min, :qsteady_max, :qoldinit, :failfactor, :calck, :alias_u0, :maxiters, :callback, :isoutofdomain, :unstable_check, :verbose, :merge_callbacks, :progress, :progress_steps, :progress_name, :progress_message, :timeseries_errors, :dense_errors, :weak_timeseries_errors, :weak_dense_errors, :wrap, :calculate_error, :initializealg, :alg, :save_noise, :delta, :seed, :alg_hints, :kwargshandle, :trajectories, :batch_size, :sensealg, :advance_to_tstop, :stop_at_next_tstop, :default_set, :second_time, :prob_choice, :alias_jump, :alias_noise, :batch, :nlsolve_kwargs, :odesolve_kwargs, :linsolve_kwargs)
│ 
│ See https://diffeq.sciml.ai/stable/basics/common_solver_opts/ for more details.
│ 
│ Set kwargshandle=KeywordArgError for an error message.
│ Set kwargshandle=KeywordArgSilent to ignore this message.
└ @ DiffEqBase ~/.julia/packages/DiffEqBase/s433k/src/solve.jl:1063

We might want to update this + change dependencies to avoid unforeseen behaviour in the future.

@Alexsp32 Alexsp32 added this to the End of 2023 update milestone Nov 13, 2023
@Alexsp32 Alexsp32 added the enhancement New feature or request label Nov 13, 2023
@reinimaurer1 reinimaurer1 self-assigned this Dec 11, 2023
@reinimaurer1
Copy link
Member

Let's have a look at this on Wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants