Fix static code analysis waaring

Author: SinghRajenM

NppJSONViewer/NppJsonViewer/JsonNode.h

@@ -1,26 +1,19 @@
 #pragma once
 #include <string>
 
-enum class JsonNodeType
+enum class JsonNodeType : short
 {
-    UNKNOWN = 0x00,
-    STRING  = 0x01,
-    NUMBER  = 0x02,
-    BOOL    = 0x04,
-    ARRAY   = 0x08,
-    OBJECT  = 0x10
-};
-
-struct JsonNodePos
-{
-    int line = 0;
-    int col  = 0;
+    UNKNOWN,
+    STRING,
+    NUMBER,
+    BOOL,
+    ARRAY,
+    OBJECT,
 };
 
 struct JsonNode
 {
     std::string  key;
     std::string  value;
     JsonNodeType type = JsonNodeType::UNKNOWN;
-    JsonNodePos  pos  = {};
 };

NppJSONViewer/external/npp/StaticDialog.cpp

@@ -51,15 +51,20 @@ HGLOBAL StaticDialog::makeRTLResource(int dialogID, DLGTEMPLATE **ppMyDlgTemplat
 	// Duplicate Dlg Template resource
 	unsigned long sizeDlg = ::SizeofResource(_hInst, hDialogRC);
 	HGLOBAL hMyDlgTemplate = ::GlobalAlloc(GPTR, sizeDlg);
-	*ppMyDlgTemplate = reinterpret_cast<DLGTEMPLATE *>(::GlobalLock(hMyDlgTemplate));
-
-	::memcpy(*ppMyDlgTemplate, pDlgTemplate, sizeDlg);
-
-	DLGTEMPLATEEX *pMyDlgTemplateEx = reinterpret_cast<DLGTEMPLATEEX *>(*ppMyDlgTemplate);
-	if (pMyDlgTemplateEx->signature == 0xFFFF)
-		pMyDlgTemplateEx->exStyle |= WS_EX_LAYOUTRTL;
-	else
-		(*ppMyDlgTemplate)->dwExtendedStyle |= WS_EX_LAYOUTRTL;
+    if (hMyDlgTemplate)
+    {
+        *ppMyDlgTemplate = reinterpret_cast<DLGTEMPLATE *>(::GlobalLock(hMyDlgTemplate));
+        if (*ppMyDlgTemplate)
+        {
+            ::memcpy(*ppMyDlgTemplate, pDlgTemplate, sizeDlg);
+
+            DLGTEMPLATEEX *pMyDlgTemplateEx = reinterpret_cast<DLGTEMPLATEEX *>(*ppMyDlgTemplate);
+            if (pMyDlgTemplateEx->signature == 0xFFFF)
+                pMyDlgTemplateEx->exStyle |= WS_EX_LAYOUTRTL;
+            else
+                (*ppMyDlgTemplate)->dwExtendedStyle |= WS_EX_LAYOUTRTL;
+        }
+    }
 
 	return hMyDlgTemplate;
 }