Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 6주차 과제 #10

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[feat] 6주차 과제 #10

wants to merge 3 commits into from

Conversation

Parkjyun
Copy link
Contributor

@Parkjyun Parkjyun commented May 31, 2024

Related Issue 📌

Description ✔️

  • jwtauthenticationfilter에서 customexception을 잡아서 HttpServletRequest에 attribute에 에러메시지를 설정
    -> JwtAuthenticationEntryPoint에서 기존의 "사용자의 로그인 검증을 실패하였습니다" 대신 401의 원인에 맞는 에러응답 반환하도록 수정

  • refreshtoken를 사용한 reissue 구현

To Reviewers

  • accesstoken, refreshtoken을 둘다 Authorization 헤더에 넣기로 했는데 옳은 방식인지 궁금합니다.
  • 현재 accesstoken과 refreshtoken이 공통적인 claim으로 issuedat, expiredat, userId, token을 갖고 둘을 구분하기 위해 tokentype을 추가하였습니다. 적절한 방법일까요?
  • JwtTokenProvider의 createToken을 통해 access, refresh token 모두 생성하고 있는데 메서드 분리를 해야할까요?? 불필요하게 메서들르 더 만드는 것 같기도 하고..

@Parkjyun Parkjyun self-assigned this May 31, 2024
@Parkjyun Parkjyun requested a review from sohyundoh May 31, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 6주차 과제
1 participant